-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for Godot 4.x #10
base: master
Are you sure you want to change the base?
Conversation
Voronoi Godot integration for Godot 4.x | ||
======================================= | ||
|
||
This fork upgrades the orginal [library](https://github.com/rakai93/godot_voronoi) to support Godot 4.x. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess this should be re-written to exclude "this fork" before being merged back.
# Create voronoi generator | ||
var points = PackedVector2Array([Vector2(0,0)]) | ||
for i in 100: | ||
randomize() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
randomize() only needs to be called once before the loop
func _draw(): | ||
# Iterate over sites | ||
for site in diagram.sites(): | ||
randomize() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here
Thank you for providing this PR! I personally don't use the project anymore and I guess it should be re-written as a GDExtension at some point, but for now I'm glad you continued the work! |
This PR Changes the type registration and header paths to play nice with the new Godot 4.x model.
! This will break the build for all Godot 3 branches including 3.5, however it should be able to build against the 3.x branch.
Build performed on Windows 11 and tested with the script described in README.md (! updated from original)